Design comparison
Solution retrospective
I put illustration-laptop and illustration-editor images as background images of divs. is it efficient? other better ways? making menu was a bit complex, any suggestions are welcome. plus any feedback is much appreciated.
Community feedback
- @DrMESAZIMPosted almost 3 years ago
Hi @Maahnoor well done .I just fell in love with you header or class="intro" , the way you did it showed great coding skills .keep it up
0 - Account deleted
Hello there! 👋
Congratulations on finishing your challenge! 🎉
I have some feedback on this solution:
-
Always Use Semantic HTML instead of
div
like<main>
<header>
, etc for more info -
Consider using the h1 element as a top-level heading only (all h1 elements are treated as top-level headings by many screen readers and other tools).
-
Images must have alternate text
- <li> elements must be contained in a <ul> or <ol>
if my solution has helped you do not forget to mark this as helpful!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord