Link Page

Community feedback

• 

  Rebecca Padgett•1,840

  @bccpadgePosted about 1 month ago

  Hello @MatheusPolletti. Congratulations on completing this challenge!!!🎉

  I have a few suggestions to improve your solution.

  Update your code to this

  body > .container {
    /* margin-top: 10%; */
    /*margin-bottom: 10%; */
    background-color: hsl(0, 0%, 12%);
    border-radius: 2%;
    /* width: 30vw; */
    padding: 1rem;
  }
  

  • Add min-height: 100vh; on the body than the .container and padding: 1rem;
  • I commented the CSS properties that you don't need using /* This is a comment*/

  The media query below is unnecessary because on mobile devices your code is too small and social media links are outside the card.

  To remove the scrollbar, add margin: 0; on the body

  @media (max-width: 764px) {
    body > .container {
      margin-top: -50%;
      width: 85vw;
      height: 55vh;
    }
  }
  

  I hope you find this useful and don't hesitate to reach out if you have any questions

  Marked as helpful

  1

  ---

  

  Matheus Cauã Polletti•30

  @MatheusPollettiPosted about 1 month ago

  @bccpadge Thanks for the corrections, they'll absolutely help me in the future. I really appreciate it

  0
• 

  ِAhmed•650

  @Axsel519Posted about 1 month ago

  good work but you need use max-height

  0

  ---

  

  MohamedHagag12•150

  @MohamedHagag12Posted about 1 month ago

  why @Axsel519

  0

  

  Matheus Cauã Polletti•30

  @MatheusPollettiPosted about 1 month ago

  @Axsel519Thanks for the tip, but could you explain more, if possible?

  0

  

  ِAhmed•650

  @Axsel519Posted about 1 month ago

  @MatheusPolletti
  Because the height was exaggerated, the max-height will ensure that it does not exceed the required height. @MohamedHagag12

  0

  

  MohamedHagag12•150

  @MohamedHagag12Posted about 1 month ago

  you mean the card ? @Axsel519

  0

  

  ِAhmed•650

  @Axsel519Posted about 1 month ago

  @MohamedHagag12 yes

  0

  

  MohamedHagag12•150

  @MohamedHagag12Posted about 1 month ago

  how much max height you want? @Axsel519

  0

  

  ِAhmed•650

  @Axsel519Posted about 1 month ago

  @MohamedHagag12 Now it works fine At first it wasn't good

  0

  

  MohamedHagag12•150

  @MohamedHagag12Posted about 1 month ago

  but i didn't make everything 😂😂 @Axsel519

  0

  

  ِAhmed•650

  @Axsel519Posted about 1 month ago

  @MohamedHagag12 I don't know but the rise was exaggerated Well the important thing is that it works now

  0