Lesson-1

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted about 2 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change .wrapper into a <main>.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website.

  • Headings should always be in order, so you never start with a <h3>. I would change it to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • "Scan the QR code" is not a heading, but a paragraph.

  • .attribution should be a <footer>, and you should use <p> for the text inside. Never have text in divs alone.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I would recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • You don't need to set width: 100% on every element! Most of these are block elements, meaning they by default take up the full width. So I would remove all instances of width: 100%.

  • Remove all instances of max-width.

  • Remove the margin on the card.

  • Remove all positioning and transform properties, they are not suitable for creating layouts.

  • To center the card horizontally and vertically, with some space between the main and the footer, I would use Flexbox on the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100svh;
  gap: 2rem;
  

  • Remove all styles on .wrapper, it doesn't need any styles.

  • Instead of %, I would use px for border-radius.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • The paragraph has poor contrast, so change the color to a darker one.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  • Remove the padding on .attribution.

  • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px.

  0
• 

  P

  pavocados•80

  @pavocadosPosted about 2 months ago

  Great job on centering everything :)

  0