Design comparison
Solution retrospective
Hi everybody! It would be great to take a look at the project and give some feedback about anything therefore I get a chance to improve myself. I am looking forward to it.
Community feedback
- @dpayne713Posted almost 4 years ago
Hi Goksel,
Looks nice! Great job. I like all your notes to yourself in your css file. Very helpful.
I’m viewing on mobile and wanted you to know that all the counters are getting pressed together in the center with no gaps between them. This is happening in both horizontal and landscape mobile safari.
If you feel up to the challenge try incorporating the flip effect. On this one I did it by animating an additional div that gets both numbers - sits on top of the top one - flips down - and then disappears and resets on the top one again - over and over.
Hope this helps.
David
2@gokselozPosted almost 4 years ago@dpayne713 Hi David. Thank you very much for your feedback. It was helpful, I have just realized that flex gap is not working on safari, therefore I updated the code. About flip effect, I couldn't do it for the first time, but I will work on it for sure. Thanks again :)
0 - @ApplePieGiraffePosted almost 4 years ago
Hey, Goksel! 👋
Good work on this challenge! 👍
I think that some of the text in the design is quite small below 600px (especially the labels below the countdown cards). Increasing those font-sizes would be a nice idea, I think! 😉
Keep coding (and happy coding, too)! 😁
0@gokselozPosted almost 4 years ago@ApplePieGiraffe Hi! ApplePie. Thank you for your feedback. I just changed it. Hope it is better now :)
0 - @DucknaroPosted almost 4 years ago
ehi bro, nice job, I would just say it's not 100% responsive. just add flex-wrap:wrap; to your flexbox and it should be fine. Nice job and keep doing challenges
0@gokselozPosted almost 4 years ago@Ducknaro Hi bro. Thanks for your feedback. On which size is there a problem with responsivity?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord