learning qr code

Community feedback

• 

  Francisco Carrillo•5,540

  @frank-itachiPosted over 1 year ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • Make sure that the <img> elements in your HTML code has an alternate (descriptive text) short text. The reason for this is that screen readers can’t translate images into text. So to fix this you can do the following <img src=”…” alt=”short text” >

  CSS🎨:

  You can use grid or flexbox to center the content no matter the viewport size. Since I use grid to achieve such purpose, you can do the following:

  body {
  	min-height: 100vh;
          display: grid;
  	align-items: center;
  	justify-content: center;
  }
  

  As I said, you can use flexbox to center the content and it will work as well.

  body {
  	min-height: 100vh;
          display: flex;
  	align-items: center;
  	justify-content: center;
  }
  

  • Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here

  I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!

  Happy <coding /> 😎!

  0
• 

  Ismael Paul•200

  @ismaelpaulPosted over 1 year ago

  Hi @PrimeSeyi,

  Congratulations, nice job!

  You don't need to use width="288px", just width="288" will be fine. And, apparently, you are not applying the font-family to your project. I can see you are using font-family: var(--base-font) but I didn't find the --base-font in your files.

  Cheers,

  Ismael Paul

  0