Skip to content
Submitted almost 2 years ago

Learning Order summary card

IbnuKhathir•40
@IbnuKhathir
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I feel like I didn't satisfy with my result. I think there is a better way to code this. Can anyone give me a feedback which part I can get better? So I can do more riset and learn at that specific problem. Thank you, Btw, sorry for my bad english

Community feedback

  • Hassia Issah•50,650
    @HassiaiPosted almost 2 years ago

    the img tag should be within the main tag and wrap <div class="attribution"> within a footer tag to fix the accessibility issue.

    You forgot to give the body a background-image with a background-size of contain a background repeat of no-repeat.

    In the media query you only have to change the background-image of the body.

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    Marked as helpful
    0
  • Sebastian•100
    @MecosLBPosted almost 2 years ago

    Hey buddy, nice job! :D I recommend you to read carefully the style-guide.md file every time you do a challenge, that file specifies the width the reference's designs are made for. Also, you can find there the fonts (I saw in your html the font's link is invalid, check that out too) and weights you need to use and even the standard font size for that challenge. Extra tip, use PixelPerfect extension so you can have a real comparision with the reference and your work. :D

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord