Lazy man trying to make a card component (Failed in the attempt)

Community feedback

• 

  P

  Dean•480

  @DeanogitPosted 11 months ago

  Hi @srjavih3,

  Great effort so far with your submission

  I noticed a couple of things that you might find interesting.

  It is not common practice to declare height and width properties in your CSS file on both the html and body element selectors, but you're right to declare them on the body.

  You've done a great job using the * selector to reset the browser defaults on box-sizing: border-box, it's possible to place margin: 0; and padding: 0 in there too instead of being in the body selector.

  I hope this helps

  Above all, well done, great work and keep going

  0

  ---

  

  Mohammed Fakih•1,590

  @javascriptor1Posted 11 months ago

  Setting height 100% on body tag only without setting same prop on html root tag would not work if you want to have 100vh effect.

  Both html and body tag should have 100% height prop in order to have viewport height of 100%.

  Other option is to give body tag only100vh instead of 100% - It will work in this case

  1

  

  P

  Dean•480

  @DeanogitPosted 11 months ago

  @javascriptor1 Thanks for clarifying, I thought it wasn't best practice to define height on the html, this article looks into it and explains it better than I understand it 🙃 here

  0