Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Layout using flexbox, HTML and Css

Brayan 30

@brayanlegarda1

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi, I'm new to Frontend development, I'm taking my first steps. "Feedback welcome".

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution consists incorrect usage of <h3> so it can cause severe accessibility errors due to incorrect usage of level-three headings <h3>
  • Every site must want only one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • In this solution there's <h3> element which is this <h3>Improve your...</h3>, you can preferably use <h1> instead of <h3>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely
  • So we want to add a level-one heading to improve accessibility
  • Example: <h1>Improve your front-end skills by building projects</h1>
  • If you have any questions or need further clarification, and feel free to reach out to me.
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

Brayan 30

@brayanlegarda1

Posted

@0xAbdulKhalid Hello and thanks for sharing your recommendations to correct the challenge. I am taking my first steps and all the help received is gratifying for me. thanks, again.

0

@ExpertoMontanero

Posted

As you see on your final solution text is not centered in your container as in example design. Use "text-align: center;" not "text-align:justify" property and it will fix it all. You forgot to change the bold text font color and height of the box differ from example design. So that change container-qr height for maybe 550 px or sth. Do not forget that you can give <h3> and <p> classes like for e.x "<p class="sub-text">". Do not use h3 when you have not used h1 and h2 before. Just start your headers from h1 tag and than go through h2, h3,h4 etc. (just cosmetics). Cheers :>

Marked as helpful

0

Brayan 30

@brayanlegarda1

Posted

@ExpertoMontanero Thank you very much for taking the time to review the code. Ok, I'll make the corrections as you suggest.

1

@ExpertoMontanero

Posted

@brayanlegarda1 Cool <3

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord