Layout using flexbox, HTML and Css

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h3> so it can cause severe accessibility errors due to incorrect usage of level-three headings <h3>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h3> element which is this <h3>Improve your...</h3>, you can preferably use <h1> instead of <h3>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Brayan•30

  @brayanlegarda1Posted over 1 year ago

  @0xAbdulKhalid Hello and thanks for sharing your recommendations to correct the challenge. I am taking my first steps and all the help received is gratifying for me. thanks, again.

  0
• 

  Tomasz Zawadzki•340

  @ExpertoMontaneroPosted over 1 year ago

  As you see on your final solution text is not centered in your container as in example design. Use "text-align: center;" not "text-align:justify" property and it will fix it all. You forgot to change the bold text font color and height of the box differ from example design. So that change container-qr height for maybe 550 px or sth. Do not forget that you can give <h3> and <p> classes like for e.x "<p class="sub-text">". Do not use h3 when you have not used h1 and h2 before. Just start your headers from h1 tag and than go through h2, h3,h4 etc. (just cosmetics). Cheers :>

  Marked as helpful

  0

  ---

  

  Brayan•30

  @brayanlegarda1Posted over 1 year ago

  @ExpertoMontanero Thank you very much for taking the time to review the code. Ok, I'll make the corrections as you suggest.

  1

  

  Tomasz Zawadzki•340

  @ExpertoMontaneroPosted over 1 year ago

  @brayanlegarda1 Cool <3

  0