layout qr-code HTML5/CSS3

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 7 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  PARAGRAPHS ⚠️:

  • This solution consists incorrect usage of <p> so it can cause severe accessibility errors due to incorrect usage of paragraph <p>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <p> element which is this <p>Improve your...</p>, you can preferably use <h1> instead of <p>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  P. Ricardo•2,370

  @pRicard0Posted 7 months ago

  Algumas dicas que você pode considerar...

  • O atributo alt da tag <img> pode ser mais descritivo. Além disso... evite utilizar a palavra "imagem" porque o elemento em si já convém com essa informação. Você poderia por, por exemplo alt="QR Code para Frontend Mentor"
  • Sobre o primeiro parágrafo, é melhor que você utilize a tag <h1> que se enquadra melhor no caso, resume bastante sobre o que o site se trata. Além disso... todo site deve conter uma h1. É muito importante para a acessibilidade e o SEO

  Marked as helpful

  0