Layout practice HTML5, CSS. Responsive design

Community feedback

• 

  Joran Minjon•610

  @DrKlonkPosted over 3 years ago

  Looks good overall!

  In the share button I see some room for improvement.

  It would be nice to have it disable if you click outside of it as well.

  It is also a bit weird that on smaller screens it covers the name and date (but maybe that was in the design).

  In the code it is not great to have it dependent on the color of the button. I would probably toggle a class (button.classList.toggle('active')) on the button on click and fix everything in the CSS based on if the button has that class or not.

  You could select the icon-social element in CSS with the "~" selector I think.

  Also, it looks like you are tyring to use BEM for naming classes, but it's not consistent. If title__content is an element of the content block, it should be content__title. After that you also use contact-user and userInfo, which are a bit ambiguous and use a different structure (hyphen and camelCase). Naming classes can definitely be tough, but can lead to much easier to read code. So it's well worth looking into! It's one of my own points of improvement as well.

  Cheers, Joran

  Marked as helpful

  1

  ---

  

  Sergey Kurshin•40

  @BeatiCodePosted over 3 years ago

  @DrKlonk Thank you!

  0