Skip to content
Submitted over 3 years ago

Launch countdown timer with Html Sass and Vanilla Js

Dark-Lover•735
@Dark-Lover
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Launch countdown timer
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

hey my friends in this challenge iv used sass again, i dont know if im doing it in the right way, if someone can check my scss file (js file too) and give me a feedback, i will be grateful. waiting your feedbacks ;)

Community feedback

  • Claudia Benito•75
    @claudiabdmPosted over 3 years ago

    Hi!

    Great work on this tough challenge. I agree with ApplePieGiraffe and I'd recommend avoiding IDs for the reasons already mentioned. I saw you have used SCSS variables so that is the way to go 👏

    I have also noticed you used fontawesome with the icons. While this is totally fine, you can also import svgs in your html or use them inline instead of using third party css. Lastly, do not forget these icons are links to social pages, so it would be nice to use an anchor tag to wrap them.

    Keep up the good work 💪

    1
    Dark-Lover•735
    @Dark-LoverPosted over 3 years ago

    hey @claudiabdm I'm very happy to hear from you, i will take your remarks in consideration in my next challenges. thank you for giving of your time to help me. i appreciate it :).

    0
  • ApplePieGiraffe•30,545
    @ApplePieGiraffePosted over 3 years ago

    Hey, Dark-Lover! 👋

    Nice work on this challenge! 🙌 Kudos for delving into Sass and JS some more! 👏

    The only small thing I have to suggest after taking a look at your Sass is to probably avoid using ID's to style things, since that's generally considered a bad practice and can making styling large sites difficult because of their high specificity. 😉

    I haven't completed this challenge yet, but a great solution for this challenge (where you might be able to learn a thing or two) that you may want to consider checking out is this one from tediko. 🙂

    Keep coding (and happy coding, too)! 😁

    1
    Dark-Lover•735
    @Dark-LoverPosted over 3 years ago

    hello my friend @ApplePieGiraffe i will keep taking all your feedbacks in consideration. its been now almost a year, iv learned a lot and still have to learn more. thank you for everything.

    1
    ApplePieGiraffe•30,545
    @ApplePieGiraffePosted over 3 years ago

    @Dark-Lover

    I'm so happy to hear I've been able to be helpful! 😊 Keep learning, Dark-Lover, and you'll improve with each solution you submit! 😀 Happy coding! 🎉

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord