Skip to content
Submitted 5 months ago

landing_page_fm

Hroldddp•60
@Hroldddp
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I finished it in under 30 minutes.

What challenges did you encounter, and how did you overcome them?

I accidentally deleted the file, I am glad I remembered my solution on my previous attempt.

Community feedback

  • Alex•3,130
    @Alex-Archer-IPosted 5 months ago

    Hi! Well done, neat work =)

    I can give a couple of suggestions of how you can improve it:

    • Try not to use br to force line break. It is often case in real projects when content could change time to time and to be dynamically rendered. So, it is better to allow the p tag to align it's content by itself.
    • Almost the same about height of the container. The better approach to not hardcode it.
    • Don't forget about main tag - it is important semantic tag. Every page should contain one.
    • Use rem values at least for font-size. It's a relative values which depends on user's settings. By default 1rem = 16px.

    Hope that helps. Good luck and keep coding =)

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord