Design comparison
Solution retrospective
My biggest challenge here was that round underline in links and navigation bar on mobile:D The first time using javascript too.
Community feedback
- @ohermans1Posted over 2 years ago
Great work on the JS! Very tidy for a first attempt.
Out of interest, is the white space around the page a design choice? I notice that it goes away for mobile view, but is there for desktop and the screenshot?
Nice job overall!
Ollie
1@AbrosssPosted over 2 years ago@ohermans1 thank you! ohh i was confused about the width of the page and i tried to narrow it, but i see now i didn't have to do it:D
1@ohermans1Posted over 2 years ago@Abrosss Looks like a fix is as simple as getting rid of the margin on body :)
1@AbrosssPosted over 2 years ago@ohermans1 right i'm going to fix it! and also the size of some elements:D thank you
1 - @hassanyahya400Posted over 2 years ago
The graphics design background image should have backgroun-size:cover and background-position:center center
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord