landing page with two column layout

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  Nice work! Your overall layout looks good. You could just do with one final round of refinements to get it matching up to the design as closely as possible.

  Just a quick heads up that the height: 100vh; declaration on the .top-section is throwing off the screenshot. As a rule, I would recommend only using vh units in very rare and very specific instances. This is because you're sizing the element based on the viewport instead of the height of the content inside, which can lead to unintended UI issues. As an example, if you look at your preview, keep the width of the browser at full-width but start reducing the height you'll see the second section starts to overlap the top section. Instead, don't set an explicit height on the parent and then just use padding and margin to space out the content within it. This way the height of the parent will be flexible based on the height of the content.

  I would also take a look at the report and try resolving those errors.

  Keep up the great work!

  0

  ---

  

  Uchechukwu Obasi•385

  @thisisobatePosted over 4 years ago

  @mattstuddert Thanks alot Matt. I'll definitely effect the changes. I'm Grateful

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  @thisisobate you're welcome 👍

  0