@PhoenixDev22
Posted
Hi arey,
Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:
HTML
- look up a bit more about how and when to write alternate text on images. Learn the differences between decorative/meaningless images vs important content like For decorative images, you set an empty
alt
to it with anaria-hidden=”true”
to remove that element from the accessibility tree. This can improve the experience for assistive technology users by hiding purely decorative images.
- Forms with proper inputs and labels are much easier for people to use. To pair the label and input, one way is an explicit label’s
for
attribute value must match its input’sid
value. Input fields without accompanying labels can lead to accessibility issues for those who rely on screen readers. If a screen reader comes across an input field without a label it will try to find some accompanying text to use as the label. (To hide the label visually but present for assistive technology, you may usesr-only
class ).
- Never use
<div>
and<span>
alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together like for .name .title.
- Instead of using a generic div to wrap the social links
class= social-link
, you put your links within an unordered list structure so that a screen reader will read out how many things are in the list to give visually impaired users the most information possible about the contents of the navigation.
- You need to manually add an aria-hidden attribute to each of your icons.
Aside these, you did great work. Hopefully this feedback helps.
Marked as helpful
@arey-dev
Posted
@PhoenixDev22 Thank you for pointing out these things. Maybe I focused more on CSS and got careless on HTML. This feedback will truly help me when working on accessibility.
I'm gonna update my HTML after I rest, and I'll also make sure to expand my knowledge on accessibility and forms.