Skip to content
Submitted about 3 years ago

Landing Page with html and sass

Ryan Calacsan•200
@ryancalacsan
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Meet landing page
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Any feedback on better responsive design or ways to clean up/make the code more efficient would be great! Thanks!

Community feedback

  • Muhammad Shajjar•1,100
    @muhammadshajjarPosted about 3 years ago

    Hi Ryan, it is well responsive and works well on all viewports. your solution is really close to the design. Well done.

    I would like to add some points.

    • try to use rem or sometimes em to avoid using px.
    • heading levels should decrease by one. h2-h6. Only one h1 per page.
    • your page should contain one main landmark. Try to use proper HTML semantics. e.g footer, main, etc.

    Good luck on your next challenges.

    Marked as helpful
    0
    Ryan Calacsan•200
    @ryancalacsanPosted about 3 years ago

    @muhammadshajjar Thanks for the advice! I did mean to convert everything to rems once i finished but it slipped my mind.

    I will also update my html with your advice as well as the generated report! Thanks again!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord