Design comparison
Solution retrospective
Need help with responsive, also I don't know how to remove margins from header+main+footer. How to change svg color? How to calc width and height of 4 images before footer. thnx
Community feedback
- @renrasPosted almost 3 years ago
There are a lot of things to improve on this project but here's a few to start with.
Just nest the margin and padding inside the * selector also since it applies to all html element.
*, *::before, *::after { font-family: 'Poppins', sans-serif; box-sizing: border-box; + margin: 0; + padding: 0; }
Your body has a max width making your page not extending on larger screens. You can apply this to the elements inside instead.
body { color: black; - max-width: 1440px; }
Your images are overflowing because they have a fixed width. What you can do is to apply properties like width:100%, max-width and min-width instead.
img { + width: 100%, + height: auto, }
You can apply this concept on your containers too.
You can change the color of the svg directly on the file by changing it's fill attribute. If I want two of them but different color I just make another copy.
Goodluck!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord