Travolgi 🍕• 31,420
@denielden
Posted
Hi Zillab, congratulations on completing the challenge, great job! 😁
Some little tips for optimizing your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example all the
div
without scope and utility - to make it look as close to the design as possible set
width: 22rem
tobackground
class - remove all
margin
from.background
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Hope this help! Happy coding 😉
0
Zillab• 20
@ZILLABB
Posted
@denielden Thanks a lot for the feedback. I will redo this challenge and also implement this new correction on my next challenges.
1
Travolgi 🍕• 31,420
@denielden
Posted
@ZILLABB you are welcome ! Keep it up
0