Landing page wit css

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Zillab, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example all the div without scope and utility
  • to make it look as close to the design as possible set width: 22rem to background class
  • remove all margin from .background class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  0

  ---

  

  Zillab•20

  @ZILLABBPosted over 2 years ago

  @denielden Thanks a lot for the feedback. I will redo this challenge and also implement this new correction on my next challenges.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @ZILLABB you are welcome ! Keep it up

  0