Design comparison
Solution retrospective
I had trouble with scaling and adjusting .svg images for different screens. I used several .svg files with different viewBox() values to fit the backgrounds... If anyone will share with better solution of this issue I will be grateful.
Community feedback
- @adarshcodesPosted over 4 years ago
Hey! @vasily-mishanin, it's fine👍 but the responsiveness isn't working well and I think you used overflow hidden for the SVG. Make the width of the whole page to 100% it would be nice. You can find many solutions to this challenge, I've also done this challenge so you can take a look at it also if you would like. Also, try to solve accessibility issues and HTML issues. Happy coding🙂
2@vasily-mishaninPosted over 4 years ago@adarshcodes thank you very much! I will give it a try :) I solved all issues except one HTML issue: "The type attribute for the style element is not needed and should be omitted." I even can't find this "style" element in my index.html🤷♂️
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord