Submitted about 2 years ago
Landing page using HTML, CSS FLEX, GRID AND BOX MODELING
@GastonSKL
Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted about 2 years ago
Hey @GastonSKL, great job on this project!
Some suggestions to improve you code:
- To center your content to your page, add the following to your <body> element:
body { min-height: 100vh; display: flex; justify-content: center; align-items: center; }- To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
Sources:
https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9
- To help keep your CSS code organized and easier to use, I suggest implementing CSS Variables. This will come in handy when building large websites, using light/dark mode, etc…
It’ll look something like this:
:root { --primary-color: value; --secondary-color: value; --tertiary-color: value; }And to use the variables you’ll use the var() function. So it’ll look like this.
h1 { color: var(—primary-color); }Heres are some articles regarding CSS Variables.
You can also take a look at my projects and see how I use it.
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties
https://www.w3schools.com/css/css3_variables.asp
Happy Coding!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord