Better5afe• 850
@better5afe
Posted
Hi Emmanuel!
Congratulations on completing the project! 🎉 I hope you had fun while making it.
Please find some minor suggestions on what can be improved below:
- Your HTML code is semantic and easy to read. The only thing that I would change is leaving alt attribute empty for images with icons only. It's not required in those situations.
- Instead of importing the Google font inside the stylesheet, I would go for the option with linking it inside the
<head>element. Importing fonts in most of the situation requires a lot of loading resources to be completly fetched. - When it comes to padding and margin, I would suggest using em and rem units to make the entire website more responsive.
- On mobile viewports the app seems to be a little too wide - it is possible to scroll it horizontally.
- If you open navigation on mobile viewport and then switch to desktop, the black overlay stays on the screen and you can't really interact with the app anymore.
- For hover states, I would suggest adding some transition on the animated properties to give the website more snatched look.
- Font for the dropdown lists seems to be a little bit too small on a desktop viewport.
- Consider increasing the with of
.hero-leftelement on a desktop viewport - the space in between left and right side is slighly too big. - You left one comment for the
.heroclass inside the CSS file 😛. - Speaking of CSS - consider using variables to store colors. It makes them easier to use and adjust their values throughout the code.
Overall, the project is very solid, keep going! I hope you find this comment helpful.
Happy Coding! 🎃👻
Marked as helpful
1
@Itz-Emmy
Posted
@better5afe Hi. Thanks for the suggestions. They are very insightful. I will make sure to effect them.
0
