Design comparison
Solution retrospective
This is my first project. Any feedback around my code would be much appreciate!
Community feedback
- @mrjayy5Posted about 4 years ago
Hi Darren,
How was working on your first project?
I think you did a great job! Working with Bootstrap is (still) a nice to have for a lot of employers. But for small projects I think it's a downside, because it's has to load the entire bootstrap framework and you will only use a small part of it.
You can speed up this page by using only Gridbox and Flexbox instead of bootstrap.
The only thing I can suggest on your code is your indent. A good use of indent ensures a readable structure. Minor indent mistakes in your CSS as well.
Keep on coding 🔥!
1@darrenevans81Posted about 4 years ago@mrjayy5 Thanks so much for the prompt feedback.
I will definitely get my head around Grid and Flexbox over the next few days. Totally understand that I don't need to use a whole framework just for a small layout.
0 - @Yemisrach15Posted about 4 years ago
Hey Darren!
Your solution looks pretty good. I don't know if you added the whitespace at the top intentionally but it's because you added
margin-top
to.container-fluid
. Maybe check into that. And you might want to add a circular border around the icons. That's all.Hope this helps🙂
0@darrenevans81Posted about 4 years agoThanks for the feedback!
I'm not even sure why I put those margins in, but I will go back and amend it.
Thanks again.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord