Frontend Mentor | Landing page using HTML and CSS coding challenge solution

@Islandstone89

Posted 4 months ago

HTML:

You don't need a class on the body, as there is only one body element.
Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.
The alt text must also say where it leads(frontendmentor website).

CSS:

It is best practice to write CSS in a separate file, often called style.css. Create one in the same folder as the index.html, and link to it in the <head>: <link rel="stylesheet" href="style.css">.
Including a CSS Reset at the top is good practice.
Use the style guide to find the correct font-family.
I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.
Remove the margin on the card.
To center the card horizontally and vertically, I would use Flexbox on the body:

display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
min-height: 100svh;

Remove all widths and heights.
Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.
font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.
Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.
On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

Marked as helpful

Landing page using HTML and CSS