Landing page using flexbox

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Nischhal, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • the qr image is broken, fix the src of image like this: <img src="images/image-qr-code.png"> or <img src="./images/image-qr-code.png"> and not <img src="/images/image-qr-code.png">
  • add descriptive text in the alt attribute of the image
  • remove all margin from .container class because with flex they are superfluous
  • add justify-content: center; flexbox property to the body for center the card
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well 😉

  Hope this help and happy coding!

  0

  ---

  

  Nischhal Bohara•30

  @nischhal-hubPosted over 2 years ago

  @denielden Oh thank you very much . I was wondering why it didn't show up when hosting in GitHub because it was running fine when locally hosted 😁 And i highly appreciate for the recommendation and advice.

  1
• 

  darthTh0t•50

  @darthTh0tPosted over 2 years ago

  Hi, the required QR code image is not visible. Please make sure that you have given proper path in img href attribute.

  0

  ---

  

  Nischhal Bohara•30

  @nischhal-hubPosted over 2 years ago

  @arnav-sahoo ok

  1