Landing page using flexbox and grid

Community feedback

• 

  ROCKY BARUA•1,090

  @DrougnovPosted almost 3 years ago

  Hello @RikkaaDev, great design. As you asked, yes, it is actually a bad practice. We should only put the logo and nav (if needed) inside the header. The actual content should be wrapped around the main tag. If you want to explore more here is a blog about when to use header

  The design looks great but the image looks a little bit small on mobile devices. Use width:100% with media queries to give it full width.

  Again, great job. Have a good day my friend :)

  Marked as helpful

  0
• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • Always wrap all of the elments inside <main> except header.

  **if my solution has helped you do not forget to mark this as helpful!

  Marked as helpful

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! RIkka Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body <main class="container"></main>

  -> Learn more on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  1