landing page using css grid and flex

Community feedback

• 

  Dimitar Radev•930

  @Mitko90Posted over 1 year ago

  Hi, nice solution.

  It looks great.

  About your question:

  I use Photoshop or Photopea or Gimp (if you're on Linux like I am) to calculate the white space used in the design images. It's quite easy to measure spacing this way

  Marked as helpful

  0

  ---

  

  Muhamed•50

  @Madmohammed22Posted over 1 year ago

  @Mitko90 Thank you, next time I'll try this technique.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by wrapping the whole content inside the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0