Landing page using CSS flex

Community feedback

• 

  MrLanter•220

  @MrLanterPosted about 2 months ago

  Hi, I hope you are doing well. Congratulations for this great work and the efforts that have been put into it!

  I would like to give you some suggestions for improvement:

  I strongly recommend that you use the <p> and <h1> tags for the text. This is important for readability, maintenance, and for SEO of the page on a browser. Here is some code that could improve this part:

  <h1 class="title">Improve your front-end skills by building projects</h1>
  <p class="description">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
  

  In the CSS file, from line 1 to line 13, you put a lot of selectors. There is a quick way to select all elements in the document, which should be much more convenient:

  * {
    	margin: 0;
  	padding: 0;
          /* other styles */
  }
  

  Text sizes should always be in rem and not px, because some people enlarge the text size in their browser settings and it might not respect their preferences. Here is a detailed explanation on this

  I hope these suggestions were helpful, have a nice day!

  1
• 

  zz1336•10

  @zz1336Posted about 2 months ago

  Could try to add sizing for the image and also the text div. The sizing could be found in figma design file. Cheers

  1