Landing page

Community feedback

• 

  Liam Frosteman Neogard•170

  @FrostemanNeogardPosted over 1 year ago

  There's definitely some good stuff here!

  Firstly, you are using CSS variables which I see a lot of people miss quite often. The desktop layout is there, and the hover effect on the "New" section works as it should.

  Here are some things that hinder you quite a bit:

  • A lot of your width and height values are hard-coded in pixels. Doing this for properties such as min-width and min-height is quite common (and important), but for layouts such as this, it's gonna be incredibly hard to have stuff display properly that way. You could try playing around with viewport values such as vw (viewport width), vh (viewport height), as well as vmin and vmax.
  • There seem to be a couple things that simply were forgotten, such as importing the font given in the starter code, though I do see that you do have a variable for the font family which is great! There are also a couple missing hover effects and the logo in the top left is missing.

  I can highly recommend designing for mobile viewports first, then expanding to the desktop view after that. I've recently started doing this and I've found it to be quite a bit easier. You might know this already, but you can press ctrl+shift+m in your browser to bring up "responsive design mode" where you can easily scale your window to specific sizes.

  Hope this helps!

  0