landing page HTML SASS JS

Community feedback

• 

  Yemisrach•1,430

  @Yemisrach15Posted over 2 years ago

  Hi Boris

  Your solution looks good both on mobile and desktop. From what I've seen you've used semantic html. Well done👏🏾. Tiny bits you could improve on imo

  • Try to look at it on larger screens. The images on graphic design and photography section are awfully stretched.
  • Some interactivities are missing (the hover effect on learn more links)
  • On footer-nav class, the html tag should be ul. I think it was typo
  • Take a look at sass mixins to reuse a style. In your case for the flexbox

  These are only my suggestions and keep in mind I'm still learning like you😅

  Marked as helpful

  1

  ---

  

  Boris•340

  @Blagoja95Posted over 2 years ago

  @Yemisrach15 Thanks for feedback.

  I had a look at my page, saw a problems and had it fixed.

  • Images now look better at larger screens.
  • Fixed a hover state for learn more links.
  • Replace div element with footer-nav class with ul element.
  • I'll use sass mixins in my next project.

  Once again thanks for your suggestions, I really appreciate it.

  0