landing page built using Flex

Community feedback

• 

  Juca Perez•270

  @jucajulian0907Posted over 2 years ago

  Great job!

  An important change you should make is to remove the images as the background of the body and place it through css as background-image with a property background-size: cover, and background-repeat: no-repeat;

  If you go through my solution of this challenge you will see how!

  Cheers!

  Marked as helpful

  0

  ---

  

  Bolu•240

  @t3ch-spawnPosted over 2 years ago

  @jucajulian0907 Thanks for the advice mate, but are there any significant benefits to this change? I mean are there any disadvantages to putting the images as the background of the body in html?

  1

  

  Juca Perez•270

  @jucajulian0907Posted over 2 years ago

  @gLitCH1904 Hello,

  From my experience a background-image + background-size: cover; It makes it much easier to cover the entire container without the image being deformed, which is exactly what happens in your solution to the challenge, it also improves performance a lot, I hope my answer helps you!

  Marked as helpful

  0

  

  Bolu•240

  @t3ch-spawnPosted over 2 years ago

  @jucajulian0907 yes this helps so much. Thanks for the advice :)

  0