Just HTML & CSS

Community feedback

• 

  Davide•1,725

  @Da-vi-dePosted about 3 years ago

  Hi, nice result on this challenge, well done!

  • HTML seems perfect, CSS not really! There's no need to repeat the media query over and over, there are two ways for writing media queries: Either you add them at end of each class or you add them at the end of the file. I'd rather write them at the end of the file, it's more organized, i don't get confused and i foucs much better at tasks!

  • I've also noticed you don't follow mobile first approach, i encourage you to do that, starting from small to large width screen, use min-width: ..., that was a very small project but you may go through very hard times for bigger designs!

  Hope it helps a little, keep coding :-)

  Marked as helpful

  1
• 

  Fernando•145

  @Faerk77Posted about 3 years ago

  Hi Davide,

  Thanks a lot for the feedback!!!.

  I understand the point of mobile first approach, in fact i have a friend that always tell me to start coding on mobile design first hehe, seems i got to hear you guys!!

  i will focus on that on future projects.

  Thanks again!!!.

  Greetings!

  1