Design comparison
Solution retrospective
yah it was a little bit difficult but finally i made it, no no it is all good, actually yes, i need some advices about uesing the grid
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi Mohammedsalih1, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
A good practice to center content is using
grid
, avoid using margin or padding to make placements, use only in the latter case! we can do it like this:GRID
body { display: grid; min height: 100vh; place-content: center; }
Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem
The rest is great!
I hope it helps... 👍
Marked as helpful0 - @Mohammedsalih1Posted almost 2 years ago
it will help me a lot, this is exactly what i was need bro thank you so much
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord