Submitted over 1 year ago

just basic html and css

Jouter• 90

@Joutee

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

I struggled a little bit with aligning everything to it's place. I'm also not sure if i made something bad with responsive design so any advice is welcomed.

Community feedback

_nehal💎• 6,710

@NehalSahu8055

Posted over 1 year ago

Hello Coder 👋.

Congratulations on successfully completing the challenge! 🎉

Few suggestions regarding design.

➨ Use Semantics for the proper design of your code.

<body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
wrap up .attribution div inside footer.
</body>

For non-decorative images give meaningful and descriptive alt like alt= "QR code to Frontend Mentor website".
Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

link.

I hope you find this helpful.

Happy coding😄

Marked as helpful

Rohit Deshpande• 870

@rohitd99

Posted over 1 year ago

Hi Jouter

Congrats on completing the challenge.

Firstly I don't think you need the media query , you can have this property on the "QRCodebox" which is max-width: 18rem and it will scale down if needed on smaller screens, if you want to scale for larger screens this article here is a good read. I also noticed you've used h2 for the title , it should be h1 you can style it as per need . Each page must have a single h1 and all headings must be in order from h1 to h6. Also I'd suggest using semantic elements like main,section than just plain old div.

Hope it helps

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord