Design comparison
Community feedback
- @MrLanterPosted about 2 months ago
Hi, this is a very good project and congratulations for this accomplishment!
I think I can give you some suggestions for improvements:
Text sizes should always be in
rem
. Some people enlarge the text size in the browser settings and setting this size topx
might not respect their preferences. Here is a useful resource on this topic - 5 mins to readIt is true that it is not a huge project, but I think it's better to give less vague class names than
container
orcontent
for the card.Do you really need to wrap a
<h1>
and a<p>
in a<div>
that is itself contained in a<div>
? I think it would be good to leave for example:<div class="text"> <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </div>
without the
.container
.I hope this helps! Good luck for the future and have a nice day!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord