[Junior Dev] Grid Layout | 7-1 SCSS + BEM

Community feedback

• 

  Guy Ezra•615

  @ezraguyPosted about 4 years ago

  Hello HailoMYM, the design looks great! awesome job! but I do have 2 suggestions:

  1. At 959px width the stars start to break so i would add a min-width like this:

  @media only screen and (min-width: 769px)
  .rating__star {
      margin-bottom: 0;
      -webkit-box-flex: 1;
      -ms-flex: 1 0 120px;
      flex: 1 0 120px;
      min-width: 135px;
  }
  

  2. I loved the way you organized the cards without margins only with align-self but around 880px width their height starts to change because the amount of text in each card is different and they look uneven. if you will remove the align-self for the first and last card at the (min-width: 769px) media query and add a height of 90% to all they will look even.

  1

  ---

  

  Hailo•90

  @HailoMYMPosted about 4 years ago

  @ezraguy Thanks for your comments, I improved my design a little and now the screenshot looks better. I changed the media breakpoint to avoid the #2 suggestion you made, it may be not the best solution as it is not a solution, just avoiding the problem, but it looks better now.

  Thanks again for looking my submission

  0