Skip to content
Submitted over 2 years ago

Js toggle and click event, grid and flex css

geoffjecrois•390
@geoffreyhach
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...FAQ accordion card
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I learned a lot from the accordion menu and had a rough time positioning the images.

Community feedback

  • IRVINE MESA•1,855
    @DrMESAZIMPosted over 2 years ago

    hi @geoffjecrois

    I had time to understand you code I have only one issue I would want to address namely

    The position of the JavaScript link would be best removed from line from line 71 to line 80 for this reason

    The best practice is to put JavaScript tags just before the closing </body> tag rather than in the <head> section of your HTML. The reason for this is that HTML loads from top to bottom. The head loads first, then the body, and then everything inside the body. If we put our JavaScript in the head section, the entire JavaScript will load before loading any of the HTML, which could cause a few problems :

    Marked as helpful
    1
    geoffjecrois•390
    @geoffreyhachPosted over 2 years ago

    @DrMESAZIM Thanks for taking the time to review my code !

    Good to know, it's something i was wondering about. Have a good day.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord