JS, SCSS, CSS variables, Sortable.js

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, nice work on this challenge, Oleh Tovkaniuk! 👍

  Your solution looks good and works rather well! 👏

  The only thing I might suggest is perhaps preloading the background images so that there is no delay between the light/dark theme button changer is pressed for the first time and the image appears. It would be a nice touch, I think!

  Also, I'm unable to check off items on the to-do list as completed for some reason. You might want to look into that to see what's going on! 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Oleh Tovkaniuk•505

  @OlehTovkaniukPosted almost 4 years ago

  @ApplePieGiraffe Good points, thanks!

  You can check off if you press at a todo's name. But if it confuses a user then it is a bad design and should be reviewed.

  I believe that i should add an event listener for that visual checkbox element too.

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @OlehTovkaniuk

  Oh, I see. Yes, I think it would be a good idea to allow users to mark items as completed by clicking on the checkbox as well as the name of each todo. Otherwise, I tried clicking on the names of the todos, and it works as expected! 👍

  1

  

  Oleh Tovkaniuk•505

  @OlehTovkaniukPosted almost 4 years ago

  @ApplePieGiraffe Thanks a lot, my friend. Could you pls also have a look at my JavaScript code structure. Could you give me few advices how to make it better?

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @OlehTovkaniuk

  I'm not super good at JS or anything—but you're JS looks fine to me. It's nice that you've separated your code into lots of functions (which helps keep your code DRY and therefore easier to maintain and stuff) and the comments make it a lot easier to understand what's going on at a glance. 👍

  I don't know if you've already seen this, but a good example of a to-do list made in vanilla JS is this awesome video from Dev Ed. If you like, you can take a look at that and perhaps learn something new! 😉

  1

  

  Oleh Tovkaniuk•505

  @OlehTovkaniukPosted almost 4 years ago

  @ApplePieGiraffe you won't believe it but I actually seen this video, moreover my function deleteCheck is from this video and this is a way of solving two features - delete and check of a todo at once. It is a super intelligent idea, isn't it

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @OlehTovkaniuk

  Haha, I actually followed the entire tutorial from start to finish as a sideproject! 😆 You're right—Dev Ed is really smart and his videos are always so informative and funny! 😄

  1
• 

  Arafat Arnob•245

  @Arnob-007Posted almost 4 years ago

  Hey Oleh Tovkaniuk, your solution seems nearly perfect to me! Drag & Drop animations are really great.

  As for js, form validation can be pretty useful. Like not accepting empty To-Dos. Otherwise everything is pretty awesome.

  Wish me good luck with sortablejs haha. Happy coding man < 3

  1

  ---

  

  Oleh Tovkaniuk•505

  @OlehTovkaniukPosted almost 4 years ago

  @Arnob-007 Hah, thanks man :3

  0