JS, CSS FLEX

Community feedback

• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can follow these steps:

  ✅ remove the debugger script and commented code from the repository

    //   const random = Math.floor(Math.random() * 200);
  console.log(response.slip.advice);
  

  ✅ it's recommended to use fetch API instead of XMLHttpRequest

  ✅ functions getQuote and getQuoteDime very similar. Try to avoid repeating yourself

  I hope my feedback will be helpful. You can mark it as useful if so 👍

  Good luck and fun coding 🤝⌨️

  1
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge

  Keep up the good work

  Your solution looks great however I think that the divider line needs some margin from the bottom using margin-bottom.

  In terms of accessibility issues simply wrap a your content between main tags. Your buttons need text so simply specify text within the tags.

  I hope this helps

  Cheers

  Happy coding 👍

  0

  ---

  

  abbos•460

  @shomurodovabbosPosted over 2 years ago

  @TheCoderGuru No it doesn't help

  0