jogo-next-js-with-tailwind-qr-code-challenge-solution

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 8 months ago

  Hello @codingjogo! 🙋🏽‍♂️

  Your solution looks excellent!

  I have a suggestion that might interest you:

  📌 If you don't have the Figma design files, I recommend using a browser extension called Perfect Pixel.

  It allows you to compare your finished project with the design images that come along when you download the project and check the (almost exact) dimensions. It's very useful!

  I hope it helps you in future projects! 😊

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  codingjogo•20

  @codingjogoPosted 8 months ago

  @danielmrz-dev

  Gonna check that later, thanks a lot!🤗

  1

  

  T

  Grace•31,090

  @grace-snowPosted 8 months ago

  @codingjogo you really don't need to do that.

  What you do need to do is

  • make your repo public so we can see the code
  • fix the colors to match the design
  • make sure the component can't hit screen edges (eg padding on the body or margin on the component)
  • fix the cut off content on landscape mobiles. I can't tell for certain but the usual cause is limiting the height of the body. Min height is fine but height is not (never limit the height of elements that contain text)

  Marked as helpful

  1

  

  Daniel 🛸•44,250

  @danielmrz-devPosted 8 months ago

  @grace-snow Can you tell me why are you so against this extension? What is so bad about it?

  That's the second time I offer this suggestion to a person and you say they "don't need it" but you don't explain exactly why.

  I've been using the extension sometimes as I still don't have access to the figma/sketch files like you do, and it's been very helpful to me.

  0

  

  T

  Grace•31,090

  @grace-snowPosted 8 months ago

  @danielmrz-dev because it distracts. Aiming for a design to the exact pixel is not the goal, it is to build a robust and accessible solution. That's where focus needs to be, especially for new learners.

  0