Design comparison
SolutionDesign
Solution retrospective
I know the spacing, and scaling is a bit off also the responsive coding is not that good I hope I could get some feedback from you all. Thank you in advance :D
Community feedback
- @rfilenkoPosted over 4 years ago
Hey, great solution overall, just a few tips:
- set width:100% on .container to get rid of overflow scroollbar;
- add box-sizing:border-box for easier calculations of the elements width;
- it's better to write all js code inside separate file, so don't use onClick attribute in html file; -try to write more smenatic markup;
- share icons should be as list items and links;
Keep practicing, Roman
2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord