Job Listings - built with React and slight design change
Design comparison
Solution retrospective
I got it working but backwards.... I either have it to where none of the listings will show until a filter is selected, then the filtered jobs show up. OR all listings show up and the filtered jobs are REMOVED instead of the not-matching jobs from disappearing. Not sure how to get it to go the other way but it's pretty much done, slightly functional lol
Community feedback
- @shashiloPosted over 4 years ago
Good work here Kele. I know this challenge takes time to style and implement. There are some things you should clean up, but you should be proud of how far you've gotten.
- I do like that you added a filter to the top of the page, but if I'm the designer or the product manager, I'd have you remove it until you click on a tag.
- If you select multiple tags from the filter, it doesn't properly function.
- On all your clickable states, there's no hover state. This is not good for usability as the user will not know if something is clickable.
- If you look at the
active-states.jpg
, it tells you what should be clickable. Currently, you cannot click on the individual job posting tags. That's how a user will filter the results. - Font size, letter spacing, padding on tags, missing box-border on each listing, etc. These are details missed.
1@YintiiPosted over 4 years ago@shashilo Thank you for the feedback, some of the changes to the functionality were personal choices. The clicking on the filters of a job to filter more jobs didn't seem intuitive to me at all. (If I found a job I was looking for I would immediately check it out the listing, not instinctively click the filtered detail to filter more options, this just didn't make sense to me.) Therefore, the filtering had to begin with some sort of obvious option set, hence the filtering box that is up there statically, sort of all the time.
The filtering, doesn't quite work right I am noticing now. It never filters it out to be completely blank it just adds other jobs that have details that are chosen(selecting RoR and HTML give two options which is seen by me now.)
And as far as some of the line spacing and such with the sketch files, I try to implement the things like letter spacing and such but the options and their values seem so drastic sometimes it doesn't look like the design at all, so I sort of eyeballed those parts.
I seem to have issues with finding some things with the Sketch files, it may be because I'm using Figma to look at them, as Figma needs to often replace things like fonts and other small details.
Thank you for the feedback it may be that I need to sit and really learn Figma inside and out to make sure I can get all the exact details I'm looking for in the design process.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord