Design comparison
Solution retrospective
What are you most proud of, and what would you do differently next time?
Perhaps the use of composable to extract the filters based on the entries and to handle the local storage. But in some aspects the solution was overcomplicated and I feel kind of uncomfortable by including so many properties in the value returned by the composable. I'm not sure if that was a good practice, probably not
What challenges did you encounter, and how did you overcome them?
The TS errors in the IDE and the logic inside the tags composable. I searched for ways to solve the issues by altering the configuration of the project; and as for the logic, I tried to simplify the initial logic using JS data structures like Set and Map
What specific areas of your project would you like help with?
The logic in the useTagFilter
. I created an internal Set where each filter applied is added as a string containing the property name and value (for example, 'tools-Vue'
), because if the entries are created by the user typing the values, it is possible that 'Vue' could be added as a language
instead of tool
or something like that. That said, I return a mapped array removing the key from the string.
I see some problems with that approach:
- I maintained the list filtering logic (the function
isResult()
) inside the composable - Too many items on the object returned by the composable
- In the
CurrentFilters.vue
component, there's no way to know from which property that value is, and that's why I created akeysByValue
map. But I feel that it was pretty much unnecessary and waste of memory - In localStorage, the full joined string is saved, ie.
tools-React,tools-Vue,contract-Full Time
for example. Saving only the values would be much more functional, but if I do so, the problem is to know from which property that value is
I wanted some feedbacks or insights about that logic, because while I am happy that I finished it and it is functional, I can see that there are bunch of flaws and I feel this is not a optimal approach
Community feedback
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord