Design comparison
Solution retrospective
I'm learning React. I'd like some feed back on my React implementation please.
Community feedback
- @c-healeyPosted over 4 years ago
Hi Matt,
I updated this to use hooks.. it's a better implementation but I wouldn't call it production quality. I looked at another hooks implementation that used context, storage and useEffect (more than I did). I probably go back to it in the future
I didn't like the context lesson I took. Throughout learning react, I keep seeing comments like 'finally an alternative to Redux, or ...' It's still uncomfortable and I sometimes wonder what kind of mind it takes to write a language that makes everything so hard and convoluted. like passing a function to a child (to a child) to update state variables. Maybe I'll see feel differently in the future.
1@mattstuddertPosted over 4 years ago@c-healey nice work! Yeah, I actually still use Redux. I haven't found a scalable way to use Context and Hooks that would be suitable for a large project yet. I'm sure it will happen though!
I'm sure you'll get used to it with practice, but I agree it can feel a little odd at times. However, it's much better than what was available before! 😅
0 - @mattstuddertPosted over 4 years ago
Hey Catherine, nice work on this challenge. You've done a really good job. I'd recommend looking into React Hooks, as they often reduce the amount of code you need to write overall. But the way you've implemented it does the job.
One small thing to tweak would be to make it so that when more than one filter is selected it continues to filter the results further. For example, if I selected React and Sass, only the positions that include both of those skills should be shown.
How are you getting on with React so far? Are you liking it?
1 - @c-healeyPosted over 4 years ago
Hi Matt, Thanks for the feedback. Narrowing it down would work nice for some of the fields, Too narrow for others like languages or tools .
I've taken one of Stephen Grider React class on Udemy. He covered hooks, routers, context ... it was a lot to take in, so I'm grateful to have some easier projects to practice on. Maybe I'll rework the jobs list with hooks to learn the difference.
Thanks again.
Cathy0@mattstuddertPosted over 4 years ago@c-healey yeah, I'd say that would be a great exercise!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord