jesica

Community feedback

• 

  KamronbekBotirjonov•200

  @KamronbekBotirjonovPosted 3 months ago

  Hi! Bro, your work came out a little rough. I think you need to reduce the button padding and margin from the bottom. I hope I helped you.

  Marked as helpful

  0
• 

  Boris•2,850

  @mkborisPosted 3 months ago

  Nice work mirodiljondev, here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around the .one
  • To improve the semantic meaning of these social media links, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered list ul to group the social media links is a better approach for both semantics and accessibility.
  • Avoid setting fixed heights and widths on elements, as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, use max-width or min-height, and prefer relative units like rem for better adaptability. Change the width of the .three to max-width and it should be defined in rem. Also remove the height completely.
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.

  Hope this helps

  0