Design comparison
SolutionDesign
Community feedback
- @KamronbekBotirjonovPosted 2 months ago
Hi! Bro, your work came out a little rough. I think you need to reduce the button padding and margin from the bottom. I hope I helped you.
Marked as helpful0 - @mkborisPosted 3 months ago
Nice work mirodiljondev, here are a few things to review
- All content should be wrapped within landmarks. Wrap a
main
tag around the .one - To improve the semantic meaning of these social media links, you should use the
a
(anchor) tag instead of thebutton
tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered listul
to group the social media links is a better approach for both semantics and accessibility. - Avoid setting fixed
heights
andwidths
on elements, as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, usemax-width
ormin-height
, and prefer relative units likerem
for better adaptability. Change thewidth
of the .three tomax-width
and it should be defined inrem
. Also remove theheight
completely. - It's best practice linking Google fonts directly in the HTML
head
section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times. - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
Hope this helps
0 - All content should be wrapped within landmarks. Wrap a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord