JavaScript, scss, mobile first

Community feedback

• 

  Amon•2,560

  @A-amonPosted over 3 years ago

  Hello! Great work~

  I have a few suggestions:

  1. Set the textContent of error message in JS instead of having a fixed message in HTML. Sometimes, the messages can be specific e.g. Please do not leave this field empty or Password has to be at least 6 characters long, etc. Doing this will also help you avoid setting the style property directly on JS e.g. style.display ,etc.

  2. Use a form instead of div for form-related items. This way, you can also addEventListener to submit event (which allows user to press Enter to submit too instead of just via clicking button)

  Marked as helpful

  1

  ---

  

  Eyad•160

  @eyad-opPosted over 3 years ago

  @A-amon Thanks a lot!

  0

  

  Amon•2,560

  @A-amonPosted over 3 years ago

  @eyad-op Glad to help!

  0