Javascript, Promises, API, Mobile First Design

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey!

  Here are some suggestions:

  • Buttons must have the discernible text, Set the attribute aria-label to describe the button.

  <button id="dice-button" aria-label="Advice Generator">
    <svg>//...</svg>
  </button>
  

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="advice-container">
        //...
     </div>
  </main>
  

  • Page should contain a level-one heading, Change <div class="advice-number" id="advice-num"> to <h1 class="advice-number" id="advice-num"> You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • All page content should be contained by landmarks, Contain the attribution with <footer>.

  <footer>
     <div class="attribution">
        //...
     </div>
  </footer>
  

  I hope this is helpful to you... Keep it up👍

  Marked as helpful

  0