JavaScript: Intersection Observer, Event Delegation, matchMedia | SCSS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello, Folarin Akinloye! 👋

  Great job on this challenge! 👍 Your solution looks good and the extra transitions and animations that you added are very nice! 😀 I especially like the on-scroll animations and the transition in/out of the mobile menu! 🙌

  The only small thing I noticed is that the "Login" button isn't clickable in the desktop layout, for some reason (perhaps it's being covered up by another element). 😉

  Your code also looks nicely commented and organized, too! 👏 I'd just suggest breaking down your main Sass file into separate files to make it easier to organize and navigate and manage your styles (since the main Sass file is very long, at the moment).

  Looking forward to your next project! 🙂

  And as usual—keep coding (and happy coding, too)! 😁

  2

  ---

  

  Folarin Akinloye•1,240

  @folathecoderPosted over 3 years ago

  @ApplePieGiraffe Thanks so much APG! 😀

  1

  

  Folarin Akinloye•1,240

  @folathecoderPosted over 3 years ago

  @ApplePieGiraffe I will look into the corrections and also compartmentalize my SCSS! I didn't do that early so people can review my code easily.

  Thanks😊

  1