Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

I've used opacity to hide and show the overlay image

@Ryuuuheiiii

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

raya 2,850

@rayaatta

Posted

Hello 👋Ryuuuuu! ≧﹏≦,

I have some suggestions you might find useful.

1 Remove the <div class= "attribution"> from the main and change it to <footer class="attribution"> And wrap the text inside a p element. This improves accessibility and SEO since it is much more semantic.

2 To body, replace

height: 100vh;

with

min-height:100vh;

This prevents content overflowing on short devices or mobile devices in landscape orientation.

I hope this helps 🙃

Your solution is awesome 👏 I especially liked the use of the clamp() function

Happy coding bro✌️

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord