Skip to content
Submitted almost 2 years ago

It's just Vanilla Html and Css

Md. Mahidun Nobi•40
@MDMahidunNobi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Adriano•38,330
    @AdrianoEscarabotePosted almost 2 years ago

    Hi Md. Mahidun Nobi, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

    We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements.

    HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices. if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

    The rest is great!

    I hope it helps... 👍

    Marked as helpful
    0
    Md. Mahidun Nobi•40
    @MDMahidunNobiPosted almost 2 years ago

    @AdrianoEscarabote I do not understand, what should i do with the report, especially the HTML validation report.

    0
    Stathis Renieris•30
    @Stathis-RenierisPosted almost 2 years ago

    @MDMahidunNobi

    Regarding your accessibility report, simply put, you should replace these dreadful generic divs with some meaningful and semantic html tags. For example, Put your main content in a <main> element to help browsers and accessibility software understand your page structure.

    2
    Adriano•38,330
    @AdrianoEscarabotePosted almost 2 years ago

    @Stathis-Renieris exactly!!

    1
    Md. Mahidun Nobi•40
    @MDMahidunNobiPosted almost 2 years ago

    @Stathis-Renieris Should I change this project's structure or do this change in my further project?

    0
  • Stathis Renieris•30
    @Stathis-RenierisPosted almost 2 years ago

    Have you paid attention to your reports? There are some important issues that need to be addressed.

    Marked as helpful
    0
    Md. Mahidun Nobi•40
    @MDMahidunNobiPosted almost 2 years ago

    @Stathis-Renieris Actually no. I'm new to this type of website and just noticed a report section up there. I will take care of it from now:)

    0
    Md. Mahidun Nobi•40
    @MDMahidunNobiPosted almost 2 years ago

    @Stathis-Renieris I do not understand, what should i do with the report, especially the HTML validation report.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord