It's bad, roast me pls

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  The attribution section in yours, don't make it absolute since when you look at it mobile, it will overlap things. Just make it position static or relative so it won't disturb the flow of the elements

  0

  ---

  

  DuhLion•20

  @DuhliPosted over 3 years ago

  @pikamart thank you, that's really helpful!

  0
• 

  Abbas Saad•260

  @AbbasSaad27Posted over 3 years ago

  Hi there! Glad to see that you completed another challenge. This one looks really great on the desktop! Good job on that! There are only a few things to improve. Adding a few media queries in between the desktop and mobile view would make the site fully responsive which is really needed! Also, there's a little white space at the bottom of the page in mobile view.. :") Overall it was it's nice! :D as always keep coding and happy coding :D

  0

  ---

  

  DuhLion•20

  @DuhliPosted over 3 years ago

  @AbbasSaad27 thank you, I will take note of adding more media queries, I just focused on the two given sizes, which is as you said really not ideal. As for the mobile view, I do not see something wrong in the live preview in VS Code... I'm probably just blind 😅

  0
• 

  Youssef Mohamed Hassan•160

  @YoussefMohamed2k19Posted over 3 years ago

  Hey @Duhli check your preview link, It's not working.

  0

  ---

  

  DuhLion•20

  @DuhliPosted over 3 years ago

  @YoussefMohamed2k19 it is now fixed

  0